Repository navigation
fix(setup): verify all, refuse encrypted SSH key - #56
Merged
Merged
Conversation
A failed verify still saves the config and exits with status 1.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.sh verifystopped at the first failed check:((errors++))returns 1 whenerrorsis 0, and the script runs underset -e. The remaining checks did not run, the summary did not print, and a full setup lost the answers of the run. Every check now runs, the config is saved, and the exit status is 1 when a check failed.The
sshstep accepted a key with a passphrase, andsecretsuploaded it asAUR_SSH_KEY. The workflow writes that key to a file and has no agent to unlock it. The step now refuses such a key and prints the commands that remove the passphrase from a copy.bats tests/ --recursive: 488 pass. shellcheck, shfmt and actionlint are clean.