Skip to content

style: fix style-guide violations in array/base/getter and array/filled#13228

Draft
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-07-02
Draft

style: fix style-guide violations in array/base/getter and array/filled#13228
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-07-02

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-07-01 20:07 UTC and 2026-07-01 20:07 UTC (SHA range c81fa285d..c38afb148).

Two style-guide violations slipped into the float16 dtype rollout and were caught by an automated post-merge audit. Both are one-line, surgical fixes; no runtime behavior changes.

Fixes

  • lib/node_modules/@stdlib/array/filled/benchmark/benchmark.length.float16.js — License header had a duplicate /** opener from the float16 codegen in c81fa28, breaking the standard single-/** shape shared by every benchmark.length.*.js sibling; collapsed to one opener. (bf336b2)
  • lib/node_modules/@stdlib/array/base/getter/docs/types/test.ts — Fix stray space before comma in float16 get4( x4 , 2 ) call added in c38afb1; brings it in line with the file's fn( x, y ) spacing convention. (11675c9)

Related Issues

None.

Questions

No.

Other

Validation audit

Checked:

  • stdlib code style compliance (parallel review, two agents cross-verified each finding against sibling float32/float64 blocks and benchmark.length.*.js siblings)
  • Obvious runtime bugs in the introduced code (two independent scans over the union diff)
  • License-header shape and JS comma-spacing rules from docs/style-guides

Deliberately excluded from this PR:

  • Anything that would require reading unchanged code outside the diff window to validate (e.g. downstream dispatch, imports)
  • Subjective code-organization or naming suggestions
  • Speculative concerns (e.g. -ffast-math interaction with the y != y NaN idiom in the anglit C benchmark) — the fe3bacee0 C-benchmark cleanup was reviewed in full and matches sibling stats/base/dists/*/quantile/benchmark/c/benchmark.c files exactly

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated post-merge audit routine: three commits merged to develop in a 24-hour window were reviewed in parallel by four independent agents (two for style-guide compliance, two for bugs); findings that were flagged by ≥2 agents and independently re-verified against the diff were applied here. A human maintainer will audit before promoting the PR out of draft.



Generated by Claude Code

claude added 2 commits July 2, 2026 12:14
Follow-up to c81fa28. The generated `benchmark.length.float16.js`
file opened its license block with two consecutive `/**` lines instead
of one, breaking the standard stdlib Apache-2.0 header format used by
every sibling benchmark file.
Follow-up to c38afb1. The float16 line in the type tests introduced a
stray space before the comma (`get4( x4 , 2 )`); every other line in
the file follows the standard `fn( x, y )` comma-spacing rule.
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/getter $\\color{green}350/350$
$\\color{green}+100.00\\%$
$\\color{green}17/17$
$\\color{green}+100.00\\%$
$\\color{green}13/13$
$\\color{green}+100.00\\%$
$\\color{green}350/350$
$\\color{green}+100.00\\%$
array/filled $\\color{green}428/428$
$\\color{green}+100.00\\%$
$\\color{green}68/68$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}428/428$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title Follow-up fixes for commits merged to develop on 2026-07-01/02 style: fix style-guide violations in array/base/getter and array/filled Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants