style: fix style-guide violations in array/base/getter and array/filled#13228
Draft
Planeshifter wants to merge 2 commits into
Draft
style: fix style-guide violations in array/base/getter and array/filled#13228Planeshifter wants to merge 2 commits into
array/base/getter and array/filled#13228Planeshifter wants to merge 2 commits into
Conversation
Follow-up to c81fa28. The generated `benchmark.length.float16.js` file opened its license block with two consecutive `/**` lines instead of one, breaking the standard stdlib Apache-2.0 header format used by every sibling benchmark file.
Follow-up to c38afb1. The float16 line in the type tests introduced a stray space before the comma (`get4( x4 , 2 )`); every other line in the file follows the standard `fn( x, y )` comma-spacing rule.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
develop on 2026-07-01/02array/base/getter and array/filled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-01 20:07 UTC and 2026-07-01 20:07 UTC (SHA rangec81fa285d..c38afb148).Two style-guide violations slipped into the float16 dtype rollout and were caught by an automated post-merge audit. Both are one-line, surgical fixes; no runtime behavior changes.
Fixes
lib/node_modules/@stdlib/array/filled/benchmark/benchmark.length.float16.js— License header had a duplicate/**opener from the float16 codegen in c81fa28, breaking the standard single-/**shape shared by everybenchmark.length.*.jssibling; collapsed to one opener. (bf336b2)lib/node_modules/@stdlib/array/base/getter/docs/types/test.ts— Fix stray space before comma in float16get4( x4 , 2 )call added in c38afb1; brings it in line with the file'sfn( x, y )spacing convention. (11675c9)Related Issues
None.
Questions
No.
Other
Validation audit
Checked:
float32/float64blocks andbenchmark.length.*.jssiblings)docs/style-guidesDeliberately excluded from this PR:
-ffast-mathinteraction with they != yNaN idiom in the anglit C benchmark) — thefe3bacee0C-benchmark cleanup was reviewed in full and matches siblingstats/base/dists/*/quantile/benchmark/c/benchmark.cfiles exactlyChecklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated post-merge audit routine: three commits merged to
developin a 24-hour window were reviewed in parallel by four independent agents (two for style-guide compliance, two for bugs); findings that were flagged by ≥2 agents and independently re-verified against the diff were applied here. A human maintainer will audit before promoting the PR out of draft.Generated by Claude Code