test: migrate stats/base/dists/beta/stdev to ULP-based assertions - #15091
Merged
Conversation
Replaces relative-tolerance comparisons in `test/test.js` and `test/test.native.js` with `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of `2`; a bound of `1` fails for one fixture case. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Yzm1pYd69FheDzXXPPnR4
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/beta/stdevfrom relative tolerance testing to ULP difference testing.delta/tolcomparisons intest/test.jsandtest/test.native.jswith@stdlib/assert/is-almost-same-value, adds the correspondingrequire, and removes the now-unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsimports.2in bothtest/test.jsandtest/test.native.js. This is the measured minimum over the full 1000-case Python fixture set: a bound of1fails for one case (alpha: 7.512224992944586,beta: 16.738584643513867), while2passes for all cases. The suite was run twice at the final bound to confirm determinism.Note on the native tests: the JavaScript and C implementations perform an identical sequence of operations (
sqrt( ( alpha * beta ) / ( alpha + beta + 1.0 ) ) / ( alpha + beta )) with a correctly roundedsqrt, and the compiled C implementation was verified to return bit-identical results to the JavaScript implementation across all 1000 fixture cases, giving the same measured minimum of2.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code, which selected the package, mirrored the conversion idiom used in already-migrated packages, and measured the minimum passing ULP bound.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_017Yzm1pYd69FheDzXXPPnR4
Generated by Claude Code