Repository navigation
feat(skills): add Astra to Sol delegation workflow - #42
notorious-d-e-v wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 29, 2026, 11:54 AM ET / 15:54 UTC (Revision 2). ClawSweeper reviewWhat this changesAdds an installable Codex skill that guides Astra to assign bounded work to Sol, choose reasoning effort, and review the worker's result. Merge readiness⛔ Blocked before merge - 5 items remain This is a distinct skill that current main does not provide. It remains useful, but implicit Sol routing conflicts with the repository's pinned worker recipe, and the submitted validation does not show a completed Astra-to-Sol delegation. Priority: P3 Review scores
Verification
How this fits togetherThe repository's skills are discovered from installed skill folders and guide agent behavior during a session. This skill takes an Astra task, routes a bounded assignment to a Sol worker through collaboration tools or the Codex CLI, and returns the result for Astra to verify. flowchart LR
A[Astra session] --> B[Installed skill]
B --> C{Delegate this task?}
C -->|Yes| D[Sol worker]
C -->|No| E[Astra works directly]
D --> F[Worker result]
F --> G[Astra review and verification]
Decision needed
Why: The proposed implicit behavior conflicts with the repository's current hard routing rule; choosing a new default requires owner intent. Before merge
Findings
Agent review detailsSecurityNone. Review metricsNone. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the existing worker recipe as the default, make Sol routing an explicit opt-in if approved, and verify one installed skill run from assignment through Astra's final review. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new optional skill, and its runtime behavior has not been demonstrated in the submitted evidence. Is this the best way to solve the issue? No: the skill fills a distinct Codex workflow, but implicit invocation is not the safest fit with the repository's current worker policy. Explicit opt-in is the narrower path. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 3f8c6a33f911. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
Thanks for the thoughtful packaging and validation. I’m closing this because model routing here is owned by |
Add an Astra-to-Sol counterpart to
codex-first: in Codex sessions using GPT-6 Astra, delegate bounded implementation or exploration to GPT-5.6 Sol at the reasoning effort Astra chooses, then have Astra review and verify the result. The existing Claude-to-Codex workflow is unchanged.The skill prefers native subagents with an explicit Sol model and fresh context, includes a CLI fallback with standard service and scoped execution, and handles unavailable models without silent substitution. It follows
skills/<name>/SKILL.md, with optional Codex UI metadata and a bundled MIT notice so it can be installed independently.Also distributed in notorious-d-e-v/agent-skills, a collection using the same folder layout.
Validation
scripts/validate-skills: validated 55 skills in this checkout.git diff --check: passed.Validation covers packaging and the documented launch contract. Live delegation across other Codex versions/accounts is not claimed; model access and tool support are explicit prerequisites.