Skip to content

fix: restore CI and prevent redirected image writes - #47

Merged
steipete merged 4 commits into
mainfrom
fix/round9-ci
Oct 10, 2026
Merged

steipete merged 4 commits into
mainfrom
fix/round9-ci

Conversation

@steipete

Copy link
Copy Markdown
Owner

Repair the default-branch CI regression caused by an outdated synthetic model catalogue, harden Nano Banana image output against symlink redirection, and update Puppeteer Core from 25.12.0 to 25.13.0 with its matching browser protocol dependencies. The Node.js runtime requirement is unchanged.

The image writer now creates new outputs exclusively through pinned, no-follow directory handles. Existing files, hard links, dangling links, and symlinked parent components are rejected; explicit relative and absolute output directories remain supported. Multiple response images retain the previous last-image behavior. Thanks @DillyRabbit for reporting #46.

Validation:

  • The original preflight suite reproduced the default-branch failure; the updated suite passes and tests every missing catalogue entry.
  • Real Pillow with synthetic Gemini responses reproduced the unsafe output behavior. All ten offline output tests now pass, including leaf/parent swaps and image conversion. The new CI test runs in an isolated Python environment.
  • Full documented CI smoke gate passed locally under nice with at most two concurrent jobs after Crabbox rejected capacity at 21/20. This includes skill metadata/sync, status, Xcode, npm, preflight, release-helper, orchestration, browser, and transcript-downloader checks.
  • After the dependency update: frozen Bun install, all six browser tests, compiled build, and CLI help passed.
  • Independent Codex review of each change: no actionable P0–P2 findings.

Refs #46. No releases, tags, package-version bumps, or deployments.

@clawsweeper

clawsweeper Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper

clawsweeper Bot commented Oct 10, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: restore CI and prevent redirected image writes This is item 1/1 in the current shard. Shard 0/1.

This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit d9f70f4 into main Oct 10, 2026
2 checks passed
@steipete

Copy link
Copy Markdown
Owner Author

Merged as d9f70f4. Exact-head PR CI and post-merge main CI are green.

Local proof under nice -n 19: all shell run blocks from .github/workflows/ci.yml passed (using installed local tools in place of apt setup), including skill metadata/link sync, status, Xcode/npm/preflight/release helpers, orchestration checks, browser compilation and transcript downloader smoke. The new isolated Python image-test step also passed exactly as written.

After updating Puppeteer: bun install --frozen-lockfile, bun test scripts/browser-tools-profile.test.ts (6 passed), bun build scripts/browser-tools.ts --compile --target bun, and the compiled CLI --help passed. Real Pillow plus synthetic Gemini responses reproduced the original output overwrite; all 10 image-safety regressions pass. No live Gemini call was needed for the filesystem proof.

Independent Codex reviews found no actionable P0–P2 findings. Crabbox refused acquisition at fleet capacity (21/20), so the explicitly authorized lightweight local fallback was used. No release, tag, package-version bump, or deployment was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant