Fix browser signer discovery - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes browser signer discovery by using portable base64url encoding and prepares release 0.16.2.
Changes:
- Replaces unsupported browser Buffer encoding.
- Adds browser-polyfill regression coverage.
- Updates package version and release documentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/indexer/mercury.ts |
Uses the portable base64url helper. |
src/indexer/mercury.test.ts |
Tests discovery with browser Buffer. |
src/version.ts |
Updates generated version. |
package.json |
Bumps package to 0.16.2. |
docs/releasing.md |
Updates checked-in release versions. |
CHANGELOG.md |
Documents the browser fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Browsers use buffer 6.0.3. It does not support Buffer.toString with the base64url encoding. Signer discovery therefore failed with Unknown encoding: base64url.
Impact
Browser applications can discover passkey signers again. No contract, binding, indexer, or relayer change is required.
Closes #2.
Checks