Support fully qualified type names for v30 by leighmcculloch · Pull Request #2798 · stellar/stellar-cli

leighmcculloch · 2026-10-13T11:39:03Z

What

Update the xdr, sdk and env crates for v30 and teach contract build to reduce the fully qualified type and event names in contract specs and to shake specs by the version recorded in the wasm.

Why

Contracts built with soroban-sdk v30 name user-defined types and events by their fully qualified path, which the CLI must read, shorten and shake correctly; this replaces #2751, #2674 and #2720.

Known limitations

The sdk, env and xdr crates are pinned to git revisions until they are released.

Copilot

🔵 Needs a closer look

Two moderate build-path issues remain unresolved; the warning wording also needs correction.

0 open findings

What changed in this PR

Updates Soroban dependencies and CLI contract builds for v30 fully qualified type/event names.

Changes:

Pins v30 SDK, environment, XDR, and related revisions.
Adds spec shaking and qualified-name reduction.
Updates fixtures, tests, interface generation, and CI workflows.

Review findings:

Cargo.toml — moderate: raw fixture builds bypass required v30 post-processing.
build.rs — moderate: --image builds bypass the new transformation.
build.rs — nit: collision warnings also cover reserved-name renaming.

File	Description
`deny.toml`	Allows temporary pinned Git dependencies.
`cmd/soroban-cli/src/utils/contract-workspace-template/Cargo.toml.removeextension`	Updates the generated SDK version to v30.
`cmd/soroban-cli/src/commands/contract/info/interface.rs`	Passes SDK version to Rust interface generation.
`cmd/soroban-cli/src/commands/contract/build.rs`	Adds version-aware shaking and qualified-name reduction.
`cmd/soroban-cli/src/commands/contract/arg_parsing.rs`	Adapts tests to widened XDR names.
`cmd/crates/soroban-test/tests/it/build.rs`	Adds qualified-name and shaking integration coverage.
`cmd/crates/soroban-test/tests/fixtures/workspace-with-qualified-names/contracts/names/src/lib.rs`	Defines qualified-name fixture types and events.
`cmd/crates/soroban-test/tests/fixtures/workspace-with-qualified-names/contracts/names/Cargo.toml`	Defines fixture contract metadata.
`cmd/crates/soroban-test/tests/fixtures/workspace-with-qualified-names/Cargo.toml`	Defines the fixture workspace.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/token/Cargo.toml`	Updates the token fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/token_renamed/Cargo.toml`	Updates the renamed-token fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/swap/Cargo.toml`	Updates the swap fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/hello_world/Cargo.toml`	Updates the hello-world fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/empty_constructor/Cargo.toml`	Updates the empty-constructor fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/custom_type/Cargo.toml`	Updates the custom-type fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/custom_account/Cargo.toml`	Updates the custom-account fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/constructor/Cargo.toml`	Updates the constructor fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/test-wasms/auth/Cargo.toml`	Updates the auth fixture to v30.
`cmd/crates/soroban-test/tests/fixtures/hello/Cargo.toml`	Updates the hello fixture.
`cmd/crates/soroban-test/tests/fixtures/bye/Cargo.toml`	Updates the bye fixture.
`cmd/crates/soroban-spec-tools/src/lib.rs`	Supports widened type and event names.
`cmd/crates/soroban-spec-tools/src/event.rs`	Updates event-name construction.
`cmd/crates/soroban-spec-tools/src/contract.rs`	Formats widened contract names.
`Cargo.toml`	Updates workspace dependencies and v30 revisions.
`Cargo.lock`	Locks updated dependency revisions.
`.github/workflows/rpc-tests.yml`	Updates the protocol version.
`.github/workflows/ledger-emulator.yml`	Updates the protocol version.
`.github/workflows/bindings-ts.yml`	Updates the protocol version.

🧠 Review effort: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🔵 Needs a closer look

Fixture generation and the contract build --image path do not apply the new spec post-processing.

0 open findings

🧠 Review effort: Lite

Copilot

🟡 Changes recommended

Pin the generated-project SDK revision and ensure contract build --image applies the same post-processing guarantees.

2 open findings

🧠 Review effort: Lite

Copilot

🟡 Changes recommended

Critical v3 capability and fixture-processing issues remain unresolved.

2 open findings

Enable spec-shaking v3 for test WASM builds · New
Advertise spec-shaking v3 in build environment · New

2 resolved since last review

🧠 Review effort: Lite

 [workspace.dependencies.soroban-sdk]
-version = "28.0.0"
+version = "30.0.0"
+git = "https://github.com/stellar/rs-soroban-sdk"
+rev = "a2e51be61dc5c179595ba5b26da7da724e253886"


+            // optimization. The var says only that this CLI shakes; which
+            // rules it shakes a given contract by comes from the model that
+            // contract's meta selects. Current and new SDK versions no
            // longer read this var, relying on the CLI version below
            // instead, but it must keep being set for past SDK versions that
            // require it.


Copilot

🔵 Needs a closer look

Build-generated and container-produced WASMs do not consistently receive the new spec processing.

2 open findings

🧠 Review effort: Lite

Copilot

🔵 Needs a closer look

contract build --image does not yet apply the same spec transformation as the local build path.

2 open findings

🧠 Review effort: Lite

Copilot

🟡 Changes recommended

Critical fixture lockfile mismatches and moderate container-build and generated-workspace issues remain unresolved.

4 open findings

🧠 Review effort: Lite

 [package]
 name = "stellar-bye"
-version = "28.1.0"
+version = "30.0.0"


 [package]
 name = "soroban-hello"
-version = "28.1.0"
+version = "30.0.0"


mootz12 · 2026-10-14T21:07:25Z

+                let (base64, spec) = Spec::spec_to_base64(stellar_asset_spec::xdr())?;
+                (base64, spec, None)


Doesn't stellar_asset_spec::xdr() need to get reduced?

stellar contract info interface --contract-id CDLZFC3SYJYDZT7K67VZ75HPJVIEUVNIXF47ZG2FB2RMQQVU2HHGCYSC --output json-formatted

shows the un-reduced names for the testnet XLM contract

mootz12 · 2026-10-14T21:09:07Z

        if: runner.os == 'Linux'
      - run: cargo build
      - run: rustup target add wasm32v1-none
      - run: make build-test-wasms


I think this job deploys contracts right? We probably need to build with CLI

Seems to be implied by this failure, that un-reduced specs cause the issue:

Rejected promise returned by test. Reason: TypeError (XdrReaderError) { message: 'XDR Read Error: saw 63 length String, max allowed is 60', }

Copilot

🟡 Changes recommended

Unresolved SAC spec-name handling, fixture lockfiles, and v3 SDK capability support block approval.

5 open findings

🧠 Review effort: Lite

+                let (base64, spec) = Spec::spec_to_base64(stellar_asset_spec::xdr())?;
+                (base64, spec, None)


update xdr and sdk crates for qualified spec names

3cc1aea

github-project-automation Bot added this to DevX Oct 13, 2026

leighmcculloch added 4 commits October 13, 2026 12:11

run quickstart on protocol 29 in ci

773ce64

decide whether to filter spec outside filter_spec

45d876c

filter and reduce spec in memory and write once

2f94acf

inline filter_spec into its call site

86159f5

leighmcculloch marked this pull request as ready for review October 13, 2026 15:27

leighmcculloch requested a review from a team as a code owner October 13, 2026 15:27

Copilot AI lite review requested due to automatic review settings October 13, 2026 15:27

Copilot started reviewing on behalf of leighmcculloch October 13, 2026 15:28

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

mention sdk type names in reduce collision warning

140bc42

Copilot AI lite review requested due to automatic review settings October 13, 2026 17:12

Copilot started reviewing on behalf of leighmcculloch October 13, 2026 17:13

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

merge main into qualified-spec-names-for-v30

c81eab6

Copilot AI lite review requested due to automatic review settings October 13, 2026 19:18

Copilot started reviewing on behalf of leighmcculloch October 13, 2026 19:19

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Comment thread cmd/soroban-cli/src/utils/contract-workspace-template/Cargo.toml.removeextension

Comment thread cmd/soroban-cli/src/commands/contract/build.rs

suggest lto setting when reduced spec has undefined names

5bc663d

Copilot AI lite review requested due to automatic review settings October 14, 2026 16:12

Copilot started reviewing on behalf of leighmcculloch October 14, 2026 16:13

View session

include true in lto suggestion

8947ca0

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings October 14, 2026 16:18

leighmcculloch mentioned this pull request Oct 14, 2026

Fix specs of Vec and Map element types without LTO stellar/rs-soroban-sdk#2135

Closed

1 of 3 tasks

Copilot started reviewing on behalf of leighmcculloch October 14, 2026 16:18

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

sanitize rust generation errors before printing

d8cdc51

Copilot AI lite review requested due to automatic review settings October 14, 2026 21:40

Copilot started reviewing on behalf of leighmcculloch October 14, 2026 21:41

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

fnando approved these changes Oct 14, 2026

View reviewed changes

leighmcculloch mentioned this pull request Oct 15, 2026

contract build can expose an empty wasm to concurrent builds #2804

Open

Merge branch 'main' into qualified-spec-names-for-v30

a685361

Copilot AI lite review requested due to automatic review settings October 15, 2026 04:38

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread cmd/crates/soroban-test/tests/fixtures/bye/Cargo.toml

[package]

name = "stellar-bye"

version = "28.1.0"

version = "30.0.0"

Comment thread cmd/crates/soroban-test/tests/fixtures/hello/Cargo.toml

[package]

name = "soroban-hello"

version = "28.1.0"

version = "30.0.0"

Copilot started reviewing on behalf of leighmcculloch October 15, 2026 07:18

View session

mootz12 reviewed Oct 15, 2026

View reviewed changes

leighmcculloch mentioned this pull request Oct 15, 2026

Reduce names in token and asset specs at compile time stellar/rs-soroban-sdk#2139

Draft

1 of 3 tasks

build test wasms with stellar contract build

b7731cc

Copilot AI lite review requested due to automatic review settings October 15, 2026 21:07

Copilot started reviewing on behalf of leighmcculloch October 15, 2026 21:08

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread cmd/soroban-cli/src/commands/contract/info/interface.rs

Comment on lines +66 to +67

let (base64, spec) = Spec::spec_to_base64(stellar_asset_spec::xdr())?;

(base64, spec, None)

Navigation Menu

Repository navigation

Support fully qualified type names for v30 - #2798

Support fully qualified type names for v30#2798
leighmcculloch wants to merge 12 commits into
mainfrom
qualified-spec-names-for-v30

leighmcculloch commented Oct 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

mootz12 Oct 14, 2026

Uh oh!

mootz12 Oct 15, 2026

Uh oh!

mootz12 Oct 14, 2026

Uh oh!

mootz12 Oct 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		let (base64, spec) = Spec::spec_to_base64(stellar_asset_spec::xdr())?;
		(base64, spec, None)

Conversation

leighmcculloch commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

mootz12 Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

mootz12 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

mootz12 Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

mootz12 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leighmcculloch commented Oct 13, 2026 •

edited

Loading