Repository navigation
Conversation
Consumes @stellar/design-system v4 rather than the page's own hand-picked palette. Every colour in the page CSS now resolves to an --sds-* token: no hex, no rgb(), no colour keywords. Lilac becomes the interactive colour - links, hovers, focus rings, nav state - and gold is retired from the page. The skill reserves gold as an accent and makes lilac primary, and warns against carrying stellar.org's marketing style onto product surfaces. On a page sitting beside the docs, the Lab and skills, lilac is what makes it look like it belongs. Typography moves to Inter and Inconsolata, the two faces SDS specifies. Both are self-hosted, so the page still makes no third-party font request; the IBM Plex Mono files are removed as they are now unused. The hand-built dark palette is gone. SDS owns both themes through .sds-theme-light and .sds-theme-dark, bridged to the page's existing toggle. Note the skill's instruction to set data-theme is wrong for v4, which ships theme classes and no data-theme selectors at all. The social card is replaced with a lilac version at the same filename and dimensions, so existing shares pick it up as caches expire. No content changes: the page renders the same 263 lines of text as main, apart from an emoji the design system does not allow as an icon. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Contributor
|
🤖 Automated message from the Stellar Triage Bot. Hi @mmazco, thanks for this PR. I saw it, but nobody asked me to review it, so I will not touch it. How to reach me:
|
Contributor
|
/triage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the Stellar Design System to
/launch/usdt0, and swaps the social card to match. No content changes — the page renders the same 263 lines of text asmain, apart from one emoji the design system does not allow as an icon.What changes
@stellar/design-systemv4 instead of the page's own hand-picked palette. Every colour in the page CSS resolves to an--sds-*token: no hex, norgb(), no colour keywords.sds-theme-light/.sds-theme-dark, bridged to the page's existing toggleusdt0-og.pngreplaced with a lilac card at the same filename and dimensions, so existing shares pick it up as caches expireOn the colour
--sds-clr-gold-09is#fdda24— the exact yellow this page already used, so the accent was always on-system. What changed is its role. The skill reserves gold as an accent, makes lilac primary interactive, and warns against carrying stellar.org's marketing style onto product surfaces. Beside the docs, the Lab and skills, lilac is what makes this page look like it belongs.Two things to flag rather than have found
SDS components are not adopted. Step 1 of the skill asks for SDS components before custom ones. This is a token-level restyle: the page keeps its own components and only resolves their colours and fonts to SDS variables. There is no SDS
Button,CardorBadgehere. For a bespoke landing page that seems a reasonable exception, but it is a deviation and worth naming.The structured data is still generated outside this repo, which is the same objection raised on #2856. Nothing here improves it — the page is produced by a script that does not live in this repository, so the
FAQPageandTechArticleblocks remain a second copy with no in-repo generator. It stays the strongest argument for porting the page tosrc/pages/launch/usdt0/index.tsx, where SDS tokens would also be considerably easier to apply.Worth knowing for other surfaces
The skill's dark-mode instruction is wrong for v4. It says to set
data-theme="dark"on<html>; the shipped stylesheet uses.sds-theme-light/.sds-theme-darkclasses and contains zerodata-themeselectors. Following it gives a theme toggle that silently does nothing.Checked
document.fonts.check, not merely declaredAfter merge
The card needs a re-scrape so existing shares refresh: X Card Validator and LinkedIn Post Inspector.
🤖 Generated with Claude Code