fix(mcp): discover all pages before registering server tools - #154
Closed
Qiyuanqiii wants to merge 10 commits into
Closed
Qiyuanqiii wants to merge 10 commits into
Qiyuanqiii wants to merge 10 commits into
Conversation
…ixed-rows fix: pin list rows to the task and stop per-delta republishes
The two README images were tracked in-repo under images-and-attachments/. Serve them from static-openapi.stepfun.com instead and drop the local copies, so cloning the repo no longer pulls a 128 KB screenshot and the demo can be updated without a commit. Replace the second image with a GIF showing StepPage publishing, and add a paragraph above it describing the feature: a local page is published as a reachable static site with one command, keeping development, debugging and delivery in the same terminal. Both the English and Simplified Chinese README carry the same copy.
…e-demo docs: host README images on the CDN and document StepPage publishing
…-url-v2 feat: update readme gif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153.
When an MCP server paginates
tools/list, Step startup currently registers only the first page and silently omits the remaining tools. Reuse the existinglistAllMcpToolshelper so startup collects the complete catalog before applying allow/deny filters and publishing it once. All pages retain the existing startup abort signal and timeout.Six new regression cases cover TUI and headless startup, an empty intermediate page, filters on later-page tools, later-page errors, shutdown cancellation, and startup timeout. All six fail on the original code and pass with the fix.
Validation:
npm run checkpassed.pnpm run build:offline,npm run check, the complete isolated./test.sh, andgit diff --exit-codeall passed in the validation run.The validation workflow exists only on the fork's CI branch. This PR changes two production modules and their existing startup test file.
AI assistance was used for investigation, implementation, and testing, as disclosed on the issue.