fix: preserve leading @ in tool paths - #163
Closed
skys-mission wants to merge 1 commit into
Closed
skys-mission wants to merge 1 commit into
skys-mission wants to merge 1 commit into
Conversation
Author
|
Rechecked the documented @ path behavior; closing this PR because the proposed change would alter the intended behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tool paths beginning with a literal
@are resolved without that character. If both@scope/sample.txtandscope/sample.txtexist,read_fileasked for the former silently reads the latter.write_filecan likewise target the wrong directory.Client reproduction
Create
@scope/sample.txtcontainingEXPECTEDandscope/sample.txtcontainingWRONG. Ask Step to callread_filewith the exact path@scope/sample.txt. Before this fix, the tool returns1: WRONG; afterward, it returns1: EXPECTED.Fix
Preserve the leading
@when resolving tool paths. CLI@filearguments are processed separately and retain their existing behavior.Verification
@-prefixed path.read_filecall.npm run check./test.shScreenshots
Before fix: Step returns WRONG when asked to read @scope/sample.txt.
Reproduction files: @scope/sample.txt contains EXPECTED, while scope/sample.txt contains WRONG.
After fix: The same request returns EXPECTED.