Conversation
Without a UI, an unapprovable confirmation (hazardous command, incomplete shell analysis, refused or unconfigured policy) returned block+terminate from StepPermissionController.handleToolCall, ending the whole run. In unattended benchmark runs this turned every mandatory-confirmation command (recursive force remove, destructive SQL, unparseable shell) into a fatal error for the trial. Add nonInteractiveDenial: "terminate" | "continue" (CLI --non-interactive-denial, env STEP_NON_INTERACTIVE_DENIAL; default terminate keeps current behavior). Under continue the call stays blocked and is reported as a failed tool result with recovery guidance, so the agent can take a safer route. Explicit deny decisions (read-only mode, per-tool deny overrides) still terminate; nothing new is approved.
MelodyVAR
force-pushed
the
fix/non-interactive-denial-recovery
branch
from
September 24, 2026 09:00
19e372a to
2540db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Without a UI (headless /
-pruns), an unapprovable confirmation — a hazardous command such as a recursive force remove, destructive SQL, incomplete shell analysis, or a refused/unconfigured policy — madeStepPermissionController.handleToolCallreturn block+terminate, ending the whole run. In unattended benchmark runs every mandatory-confirmation command became a fatal error for the trial.Change
Add
nonInteractiveDenial: "terminate" | "continue":--non-interactive-denial <mode>, envSTEP_NON_INTERACTIVE_DENIALterminatekeeps current behaviorcontinue, the call stays blocked and is reported back to the agent as a failed tool result with recovery guidance, so the agent can take a safer route instead of dyingVerification
packages/coding-agent:args.test.ts,step-permissions.test.ts,suite/step-command-approval.test.ts— 192 tests passtsgo --noEmit) passes--help