Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill loading had inconsistent behavior across discovery, invocation, and compaction: directory symlink cycles caused repeated traversal,
--no-skillsstill scanned skill trees, nested ignore rules lost their scope, and multi-line/skill:namecommands were not expanded. Step also advertisedreadwhen its active tool wasread_file.Fix discovery with canonical directory visitation and a shared directory-scoped ignore matcher. Skip automatic skill collection before traversal when disabled, while retaining explicit CLI paths and correctly identifying skills-only packages. Align the SDK helper with project-first precedence and accept BOM-prefixed skills in the execution-environment loader. Generate the catalog instruction for the active read tool and split skill commands on whitespace.
Built-in compaction now preserves actually loaded skill instructions independently of the generated summary. Successful reads and explicit invocations are recorded with their locations/read ranges, carried in compaction metadata, and appended verbatim to the resulting context. Full rereads replace older content, repeated ranges are deduplicated, and reused tool-call IDs are correlated in message order. Step's read/write/edit aliases also participate in file tracking. Custom compaction extensions retain ownership of their summaries.
Validation:
pnpm run build:offlinepassed.pnpm run checkpassed, with Biome run without--write.--no-skills; the full loader completes in about 50ms where the original exceeded a 3s external scan limit.