Repository navigation
Qualify exclusions by revision, so one configuration serves every revision - #88
Merged
Merged
Conversation
…ision An exclusion is now test.exclude.<revision id>.<procedure id> = <reason>, e.g. test.exclude.3.1r1.8.26.2. A run excludes only its own revision's procedures, and every run, -disabled and -describe check every exclusion against the revision it names, whichever revision runs. An unqualified key, an unknown revision, an id the named revision doesn't have, a section or `all` is a configuration error. Closes #87
Both ids have dots, so test.exclude.<revision id>/<procedure id> splits at the first "/". A key without one is an error giving the syntax and the revisions; an unknown revision is worded as for -rev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclusions now name the revision they're for:
Checking every exclusion against the revision being run meant a configuration that excluded a 3.1r1 procedure couldn't run 2.7. Unqualified ids were also ambiguous across revisions: 8.23 is Device Attributes in 2.7 and Specific Point Ranges in 3.1r1.
-disabledand-describecheck every exclusion, whichever revision runs. The key splits at the first/. A key without one is an error giving the syntax and the revisions. An unknown revision is an error worded as for-rev. An id the named revision doesn't have, a section, orallis an error.Excludedoutcome,RunSummary.exclusions, the report and the CLI output.The
-write/-optionsexample, README, docs/manual-testing.md and docs/automation.md use the new form.Closes #87