Repository navigation
Check the Windows launcher before each release, not on every pull request - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli (windows-latest)builds the CLI zip on Windows and checks its launcher (bin\dnp3c.cmd): it runs with Java 21, also from aJAVA_HOMEwith spaces, and rejects Java 11 and a missing Java. The launcher hasn't changed since the first commit, but every pull request and merge-queue run waited on this job, the slowest and so far the flakiest.windows-launcherjob runs the same check when a tag is pushed, and the release job needs it, so a broken launcher stops the release before anything is published to Maven Central.cli (ubuntu-latest)stays, building the zip and checking the Linux launcher on every pull request.main's required checks needcli (windows-latest)removed, or the merge queue waits for a check that no longer runs.