Repository navigation
Turn off Nagle's algorithm on TCP connections - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnp3c's TCP connections left Nagle's algorithm on, so a small write sent right after another could wait for the first to be acknowledged before it went out. That shifts the timing the procedures check, e.g. a confirm followed at once by a request. DNP3 stacks turn Nagle off for this reason; the dnp3 library does by default.
Every TCP connection now sets
TCP_NODELAY: it's set inTcpClientChannelFactory.connect, which both the channel factory and the driver's link status probe connect through. A new test checks a connection has it set, and fails without the change.