fix: stage Loupe.Quick from LoupeEditor build output - #511
Closed
mberrys wants to merge 2 commits into
Closed
Conversation
qt_add_qml_module writes to CMAKE_CURRENT_BINARY_DIR/Loupe/Quick under LoupeEditor, not the top-level build tree. Unblocks Linux_AppImage and Windows_MSI Deploy Qt steps. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Resolve Loupe->Loop rename conflicts by taking dev Loop naming while preserving LoopEditor/Loop/Quick staging path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open the existing package-boundary topic branch against dev for review. It corrects the Qt Quick build-output staging paths and workflow contract expectations.