fix(ci): install gperf build deps in Linux AppImage workflow - #523
Draft
mberrys wants to merge 2 commits into
Draft
fix(ci): install gperf build deps in Linux AppImage workflow#523mberrys wants to merge 2 commits into
mberrys wants to merge 2 commits into
Conversation
vcpkg's gperf port requires autoconf, autoconf-archive, automake, and libtool (libtoolize) from the system package manager. Without them the Linux_AppImage workflow fails at 'VCPKG: Install Project Dependencies' when building fontconfig's gperf dependency. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
The version and capabilities probes run before $pdfTool was assigned, causing Windows_MSI to fail at Validate staged install tree under Set-StrictMode. Move the Join-Path assignment above the first use. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Linux AppImage
Linux_AppImage fails at VCPKG: Install Project Dependencies when vcpkg tries to build
gperf:x64-linux@3.3(a fontconfig dependency). The vcpkg port requires system packages that are not installed on the runner:Observed on runs 33613203166, 33612490967, and 33612887274.
Windows MSI
Windows_MSI fails at Validate staged install tree on run 33612493911 (SHA
20baab09).scripts/smoke-test-install.ps1calls& $pdfTool --versionbefore$pdfToolis assigned, which throws underSet-StrictMode.Fix
autoconf,autoconf-archive,automake, andlibtoolto the Install dependencies step in.github/workflows/LinuxInstall.yml.$pdfToolimmediately after the required-file assertions inscripts/smoke-test-install.ps1, before the version/capabilities probes.Verification
python3 scripts/agent/check-change.py --base origin/cdx/session-07-package-proof— passubuntu-24.04runnersNotes
cdx/session-07-package-proofso Session 07 package re-runs pick up the fix.