fix: toggle play button icon during playback in LEGO Bricks#7456
fix: toggle play button icon during playback in LEGO Bricks#7456santhosh-7777 wants to merge 2 commits into
Conversation
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 48.09% | Branches: 39.61% | Functions: 52.88% | Lines: 48.49% |
kartikktripathi
left a comment
There was a problem hiding this comment.
this is a good change, I would only suggest you to handle the operation of stopping the flow when we click on the pause button once it has started.
|
Also, I just checked, this branch needs to be rebased as three test suites are missing. (162 of 165 present, 3 test suites from the master branch are not visible) |
10d399c to
c436b0d
Compare
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 48.29% | Branches: 39.9% | Functions: 52.99% | Lines: 48.69% |
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 48.29% | Branches: 39.9% | Functions: 52.99% | Lines: 48.68% |
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
PR Category
Summary
Resolves #7455 — the play button icon in the LEGO Bricks
widget did not toggle during playback.
Changes
js/widgets/legobricks.js
handler when playback starts
_stopPlayback() when playback ends
Test Results
Before: Play button icon remains▶️ throughout playback▶️ when done
After: Icon toggles to ⏹️ during playback and reverts to
Checklist