Fix help widget outside-click minimize behavior#7467
Conversation
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 48.12% | Branches: 39.68% | Functions: 52.91% | Lines: 48.52% |
|
@Ashutoshx7 I have drafted the solution for this. Could you please review it when you have a moment? |
|
@walterbender ur views on this ? |
|
The feature is working fine locally , tested successfully. However, it would be good to have the code owners’ opinion . i think this is needed .. I reccomend to also add a test that clicking inside the focused window does not trigger _rollup() . |
I agree with @Chaitu7032 here. Could you please add a test for this specific behavior? Regarding the feature itself, I’m not fully sure how helpful this would be. I might be biased because of my background, so it would be better to discuss this in the Sunday meeting since it’s related to UX. |
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 48.13% | Branches: 39.69% | Functions: 52.91% | Lines: 48.53% |
|
I have added the requested test to verify that clicking inside the focused window does not trigger the Regarding the UX discussion, I understand the concerns and I would be happy to join the Sunday meeting. |
tested this out locally works fine @lavjeetrai we have sunday meet at 4:30 ist you can join and we can discuss with admin itself |
|
thanks @Ashutoshx7 ,from where i can join the meeting?? |
join musicblocks matrix channel first and then in channel description you can find the link |
|
I don't see the point of this change. |
|
Thanks for the review! I suggested this because, in crowded workspaces, the help widget can block content behind it. Allowing an outside click to minimize it felt like a convenient way to quickly regain workspace visibility. |
Summary
This PR fixes the help widget minimize behavior when the user clicks outside the panel to improve UX.
Previously
What changed
After-change
Screen.Recording.2026-06-04.012914.mp4
Ran
npx jest js/__tests__/widgetWindows.test.js --runInBand --coverage=falsefor verification.Category