Skip to content

Fix help widget outside-click minimize behavior#7467

Open
lavjeetrai wants to merge 2 commits into
sugarlabs:masterfrom
lavjeetrai:fix-help-panel
Open

Fix help widget outside-click minimize behavior#7467
lavjeetrai wants to merge 2 commits into
sugarlabs:masterfrom
lavjeetrai:fix-help-panel

Conversation

@lavjeetrai

@lavjeetrai lavjeetrai commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the help widget minimize behavior when the user clicks outside the panel to improve UX.

Previously

image

What changed

  • Clicking anywhere outside the help window now minimizes/rolls up the widget.
  • The rolled-up state now uses the same visual behavior as the normal minimize control, including the visible plus/minimize indicator.
  • Added a regression test to ensure outside-click minimize behavior remains working.

After-change

Screen.Recording.2026-06-04.012914.mp4

Ran npx jest js/__tests__/widgetWindows.test.js --runInBand --coverage=false for verification.

Category

  • Feature

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🧪 Jest Test Results

✅ All Jest tests passed! This PR is ready to merge.

Coverage: Statements: 48.12% | Branches: 39.68% | Functions: 52.91% | Lines: 48.52%
Master Coverage: Statements: 48.29% | Branches: 39.83% | Functions: 52.98% | Lines: 48.69%

@github-actions github-actions Bot added feature Adds new functionality size/M Medium: 50-249 lines changed area/javascript Changes to JS source files area/tests Changes to test files labels Jun 3, 2026
@lavjeetrai

Copy link
Copy Markdown
Contributor Author

@Ashutoshx7 I have drafted the solution for this. Could you please review it when you have a moment?

@lavjeetrai

Copy link
Copy Markdown
Contributor Author

@walterbender ur views on this ?

@Chaitu7032

Chaitu7032 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

The feature is working fine locally , tested successfully. However, it would be good to have the code owners’ opinion . i think this is needed ..

I reccomend to also add a test that clicking inside the focused window does not trigger _rollup() .

@Ashutoshx7

Copy link
Copy Markdown
Collaborator

The feature is working fine locally , tested successfully. However, it would be good to have the code owners’ opinion . i think this is needed ..

I reccomend to also add a test that clicking inside the focused window does not trigger _rollup() .

I agree with @Chaitu7032 here. Could you please add a test for this specific behavior?

Regarding the feature itself, I’m not fully sure how helpful this would be. I might be biased because of my background, so it would be better to discuss this in the Sunday meeting since it’s related to UX.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Jest Test Results

✅ All Jest tests passed! This PR is ready to merge.

Coverage: Statements: 48.13% | Branches: 39.69% | Functions: 52.91% | Lines: 48.53%
Master Coverage: Statements: 48.36% | Branches: 40.08% | Functions: 53.07% | Lines: 48.75%

@lavjeetrai

Copy link
Copy Markdown
Contributor Author

I have added the requested test to verify that clicking inside the focused window does not trigger the _rollup() function.

Regarding the UX discussion, I understand the concerns and I would be happy to join the Sunday meeting.

@Ashutoshx7

Copy link
Copy Markdown
Collaborator

I have added the requested test to verify that clicking inside the focused window does not trigger the _rollup() function.

Regarding the UX discussion, I understand the concerns and I would be happy to join the Sunday meeting.

tested this out locally works fine
@walterbender need your opinion here

@lavjeetrai we have sunday meet at 4:30 ist you can join and we can discuss with admin itself
as this is a ux change we should draw thier attention on this

@lavjeetrai

Copy link
Copy Markdown
Contributor Author

thanks @Ashutoshx7 ,from where i can join the meeting??

@Ashutoshx7

Copy link
Copy Markdown
Collaborator

thanks @Ashutoshx7 ,from where i can join the meeting??

join musicblocks matrix channel first and then in channel description you can find the link

@walterbender

Copy link
Copy Markdown
Member

I don't see the point of this change.

@lavjeetrai

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I suggested this because, in crowded workspaces, the help widget can block content behind it. Allowing an outside click to minimize it felt like a convenient way to quickly regain workspace visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/javascript Changes to JS source files area/tests Changes to test files feature Adds new functionality size/M Medium: 50-249 lines changed

Projects

Development

Successfully merging this pull request may close these issues.

4 participants