Skip to content

refactor: remove createjs.Tween dependency from render loop and tick handler#7470

Open
Mohd-Ali-Creator wants to merge 4 commits into
sugarlabs:masterfrom
Mohd-Ali-Creator:fix/remove-tween-dependency
Open

refactor: remove createjs.Tween dependency from render loop and tick handler#7470
Mohd-Ali-Creator wants to merge 4 commits into
sugarlabs:masterfrom
Mohd-Ali-Creator:fix/remove-tween-dependency

Conversation

@Mohd-Ali-Creator

@Mohd-Ali-Creator Mohd-Ali-Creator commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

PR Category

  • Bug Fix
  • Feature
  • Performance
  • Tests
  • Documentation

Summary

Removes createjs.Tween.hasActiveTweens() calls
from two locations as part of the CreateJS
migration effort (Issue #6612).

Changes

1. _startRenderLoop (line ~545)

Removed createjs.Tween.hasActiveTweens() check.
All render conditions already covered by:

  • this.stageDirty — visual changes
  • hasActiveGifs — GIF animations
  • isInteracting — drag/select states

2. __tick function (line ~5099)

Removed createjs.Tween.hasActiveTweens()
from condition. this.update flag is sufficient.

Why This Is Safe

All animation states covered by Tween tracking
are already handled by existing flags.
No behavioral change — removes CreateJS dependency.

Note on Jest Failure

The failing test (aidebugger.test.js) is a
pre-existing failure on master branch —
NOT introduced by this PR.

Verified by running test on clean master:
npx jest aidebugger.test.js → FAILS on master too

Reference: #7403 (raised by @kartikscodes)

cc @walterbender @sum2it

Testing

  • App loads correctly ✅
  • Block dragging works ✅
  • Turtle animations work ✅
  • Jest: 5383/5384 tests passing ✅
  • 1 pre-existing failure in aidebugger.test.js
    exists on master (unrelated to this change)

Part of CreateJS migration: #6612

cc @walterbender @sum2it @omsuneri

@github-actions github-actions Bot added performance Improves performance (load time, memory, rendering) size/S Small: 10-49 lines changed area/javascript Changes to JS source files labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🧪 Jest Test Results

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Coverage: Statements: 48.23% | Branches: 39.78% | Functions: 52.95% | Lines: 48.63%
Master Coverage: Statements: 48.29% | Branches: 39.83% | Functions: 52.98% | Lines: 48.69%

Note: These failures may be introduced by this PR or may already exist in the master branch.
Tip: Update your branch with the latest master and rerun tests.
If the same failures are present on master, they are likely not introduced by this PR.

Failed Tests:

aidebugger.test.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/javascript Changes to JS source files performance Improves performance (load time, memory, rendering) size/S Small: 10-49 lines changed

Projects

Development

Successfully merging this pull request may close these issues.

1 participant