refactor: remove createjs.Tween dependency from render loop and tick handler#7470
Open
Mohd-Ali-Creator wants to merge 4 commits into
Open
refactor: remove createjs.Tween dependency from render loop and tick handler#7470Mohd-Ali-Creator wants to merge 4 commits into
Mohd-Ali-Creator wants to merge 4 commits into
Conversation
Contributor
|
🧪 Jest Test Results ❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Coverage: Statements: 48.23% | Branches: 39.78% | Functions: 52.95% | Lines: 48.63% Note: These failures may be introduced by this PR or may already exist in the master branch. Failed Tests: |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Summary
Removes
createjs.Tween.hasActiveTweens()callsfrom two locations as part of the CreateJS
migration effort (Issue #6612).
Changes
1. _startRenderLoop (line ~545)
Removed
createjs.Tween.hasActiveTweens()check.All render conditions already covered by:
this.stageDirty— visual changeshasActiveGifs— GIF animationsisInteracting— drag/select states2. __tick function (line ~5099)
Removed
createjs.Tween.hasActiveTweens()from condition.
this.updateflag is sufficient.Why This Is Safe
All animation states covered by Tween tracking
are already handled by existing flags.
No behavioral change — removes CreateJS dependency.
Note on Jest Failure
The failing test (aidebugger.test.js) is a
pre-existing failure on master branch —
NOT introduced by this PR.
Verified by running test on clean master:
npx jest aidebugger.test.js → FAILS on master too
Reference: #7403 (raised by @kartikscodes)
cc @walterbender @sum2it
Testing
exists on master (unrelated to this change)
Part of CreateJS migration: #6612
cc @walterbender @sum2it @omsuneri