docs: add REVIEW_GUIDELINES.md#7506
Open
UtkarshAnandd wants to merge 1 commit into
Open
Conversation
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Contributor
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 48.37% | Branches: 40.07% | Functions: 53.06% | Lines: 48.76% |
Collaborator
|
@vyagh @zealot-zew guys your thoughts on this |
vyagh
requested changes
Jun 12, 2026
Comment on lines
+20
to
+24
| ## Contributor Journey | ||
| 1. Start with small fixes and suggest changes | ||
| 2. After 8-10 merged PRs, request approval rights | ||
| 3. With experience, propose performance improvements | ||
| and new features — discuss with mentors first No newline at end of file |
Collaborator
There was a problem hiding this comment.
Out of scope for review guidelines, right?
Collaborator
|
ssz2605
reviewed
Jun 12, 2026
Collaborator
There was a problem hiding this comment.
Few more points that could be added under the contributor checklist:
- For feature, UI/UX, or workflow changes, include before-and-after screenshots, GIFs, or a short video demonstrating the change.
- For performance-related changes, provide before-and-after benchmark results, performance graphs, or screenshots of relevant metrics along with a brief explanation of the measurable impact created by the optimization.
This helps reviewers understand the change more quickly, validate the claimed improvements, and reduces the effort required to reproduce the results locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes discussion #6925
Compiling the Review Guide discussed in the Ideas thread into a
REVIEW_GUIDELINES.md file, incorporating suggestions from:
The guide covers: