chore(scim): mount the SCIM router in the main route tree - #2658
Merged
Conversation
xlgmokha
marked this pull request as ready for review
July 30, 2026 21:37
xlgmokha
force-pushed
the
xlgmokha/auth-1362b
branch
from
August 4, 2026 16:18
52eee62 to
8a28f88
Compare
Move the `/scim/v2` routes from the top level into the `r.Route("/")`
subtree so they pick up isValidExternalHost along with the rest of
the API.
xlgmokha
force-pushed
the
xlgmokha/auth-1362b
branch
from
August 4, 2026 16:43
f1a6d3c to
6ea716d
Compare
cstockton
reviewed
Aug 4, 2026
cstockton
left a comment
cstockton
left a comment
Contributor
There was a problem hiding this comment.
This one has been approved but I did prefer the previous SendJSONAs - Helpers like this often end up simply duplicating the API's the libraries they wrap overtime.
Not blocking this or anything, am okay with the shared/json.go file but we should include tests for it if we think keeping it is valuable.
Contributor
Author
|
I added tests for this in https://github.com/supabase/auth/pull/2672/files#diff-73c59f4aa706921ea09d2aabd60a0987e451274119ea06d325f6142a1193b66cR12 but I can revert back to my original implementation of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Moves the SCIM routes into the main route tree and hands the feature-flag check to the API layer, so the SCIM package stops carrying that concern.
Extracted from #2643.
What is the current behavior?
/scim/v2is mounted at the top level of the router, outside ther.Route("/")block, so it does not runisValidExternalHostthe way the rest of the API does.The feature flag is enforced by
scim.Server.Middleware, which means the SCIM package has to know aboutExperimental.ScimEnabledand depend onapierrors.What is the new behavior?
r.Route("/")subtree, so they runisValidExternalHostalongside every other endpoint.(*API).requireScimServerEnabledreplacesscim.Server.Middleware, following the existingrequireOAuthServerEnabled,requirePasskeyEnabled, andrequireCustomOAuthEnabled.The three endpoints still return 501. With the flag off they still return the same 404, which the test now pins on the body rather than the status code alone:
{ "code": 404, "error_code": "feature_disabled", "msg": "SCIM server is disabled" }Additional context