Repository navigation
Conversation
The published CLI config schema now carries `"x-secret": true` on every field the schema marks secret, so tooling can tell secrets apart without parsing descriptions. The project-config schema already omits secret fields, so it is unchanged.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Confirmed Claude's single nit: the published-schema test walker skips $defs. Neither current schema uses definitions, so this is a future coverage gap, not a current schema defect. No additional findings. Tests were not run because dependencies are absent.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | packages/config/src/json-schema-document.unit.test.ts:29 |
test-coverage |
claude | The secret-marker walker skips $defs, so the project-config negative assertion would miss secret markers inside definitions if the generated schema starts using them. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
jgoux
approved these changes
Oct 26, 2026
Coly010
deleted the
columferry/cli-2858-publish-secret-markers-in-the-config-schemas
branch
October 26, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret()andenv({ secret: true })mark config fields withx-secret, but the publishedconfig.schema.jsonnever carried it, because the JSON Schema generator only emits standard keywords. The only hint a field held a secret was the "do not commit" note in its description, which tools can't act on.The published CLI config schema now has
"x-secret": trueon every field the schema marks secret. That includes theremotes.*copies and the values ofdb.vaultandedge_runtime.secrets. Editors ignore unknown keywords, so validation and completion behave the same, and nothing changes in how config is loaded.toPublishedJsonSchemaDocumentnow generates both published schemas itself and lets onlyx-secretthrough, so internal annotations likex-env-deferredstay outproject-config.schema.jsondoesn't change, since it already leaves secret fields out altogetherapps/docs/public/cli/config.schema.jsonis regenerated, and the only change is the added markersLinked issue
Closes CLI-2858