Skip to content

fix(cli): show ethereum web3 example in init config (CLI-2854) - #7334

Open
7ttp wants to merge 2 commits into
developfrom
7ttp/cli-2854-fixinit-correct-web3-standard-attribution-and-add-missing
Open

7ttp wants to merge 2 commits into
developfrom
7ttp/cli-2854-fixinit-correct-web3-standard-attribution-and-add-missing

Conversation

@7ttp

@7ttp 7ttp commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

TL;DR

adds a commented [auth.web3.ethereum] example to the config.toml from supabase init, matching the web3 docs, drops the wrong EIP-4361 citation from the solana comment and fixes the max_rows comment typo

ref:

@7ttp 7ttp self-assigned this Oct 26, 2026
@7ttp
7ttp requested a review from a team as a code owner October 26, 2026 15:46

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed. Confirmed one cosmetic, pre-existing documentation error: the Solana comment incorrectly attributes SIWS to EIP-4361. The added Ethereum example and corresponding test expectations are consistent; no runtime defects were identified.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/shared/init/project-init.templates.ts:342 documentation claude The Solana comment incorrectly identifies EIP-4361 as the SIWS standard. EIP-4361 specifies Sign-In with Ethereum.

Findings outside the diff

  • ⚪ NIT apps/cli/src/shared/init/project-init.templates.ts:342 — The Solana comment incorrectly identifies EIP-4361 as the SIWS standard. EIP-4361 specifies Sign-In with Ethereum.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(init): correct web3 standard attribution and add missing ethereum provider in config.toml template

1 participant