Repository navigation
Conversation
Add a oneshot unit shipped in the postgres env profile. After each postgres start it runs ALTER DATABASE ... REFRESH COLLATION VERSION for glibc en_US databases whose recorded and actual glibc versions both sit in 2.31..2.44, where English ordering is identical. Other databases are left alone. The build fails when nixpkgs glibc is above 2.44. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PostgreSQL Extension Dependency Analysis: PR #2572
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2572
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency ClosureOrioleDB 17 Dependency ChangesExtracting...[Comment body truncated] |
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 7 -> 8 (2 paths added, 1 paths removed, delta +1, disk usage +3.0KiB).x86_64-linux: Closure size: 7 -> 8 (2 paths added, 1 paths removed, delta +1, disk usage +3.0KiB). |
Take psql from the postgres env profile PATH instead of a per-version build input, so a single package serves every Postgres version. Drop Nice and ConditionHost from the unit and merge the failure subtests in the VM test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… profile Move the package into its own directory and add it to the site envs. The unit stays a plain source file that the package installs verbatim, and ansible links it from the site profile instead of copying it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replace the shell script with a SQL file run by psql from the unit. The package installs the SQL and the unit, ansible links the unit and postgresql.service wants it. Shrink the VM test to a table of cases. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…sion-refresh # Conflicts: # ansible/files/postgresql_config/postgresql.service
…sion-refresh # Conflicts: # nix/packages/site-env.nix
This comment has been minimized.
This comment has been minimized.
Refs: MPG-1396 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Found 6 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Reset the failed state before restarting postgres so is-failed cannot match the previous run. Print the unit journal when the testinfra check finds the unit not active. Refs: MPG-1396 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…database Refs: MPG-1396 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We need to update glibc.
A glibc update 2.31->2.34->2.39->2.40->2.42 makes Postgres warn "collation version mismatch" on existing databases, even when English ordering is unchanged (glibc only ships with English and C locales).
What
postgresql-collation-refresh.servicesystemd unit that runs after each postgresql startpostgresql-collation-refresh.sqlfor each db, if collation is glibc en_US.UTF-8 2.31-2.44 and != target, runALTER DATABASE ... REFRESH COLLATION VERSION.VM tests.
MPG-1396