fix: support jsonb expression filters - #2104
Open
qtjg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for filtering Postgres Changes subscriptions on a JSONB text-extraction expression such as
data->>organization_id=eq.org_123.Fixes #1090.
What changed
jsonb_column->>keyfilter expression during subscription creation.jsonbtype and validate the comparison value as text.->>operator during row-visibility evaluation.data jsonbfield to the shared integration fixture.The implementation keeps the existing filter wire format and equality-operator machinery. It does not use dynamic SQL for the JSONB key; the base column and key are parsed and validated before the value is passed to the existing comparison function.
Testing
data->>organization_id=eq.org_123passes.git diff --checkpasses.Coordination note
A previous comment on issue #1090 says that
krishvsoniwanted to work on this issue. I am opening this PR transparently so maintainers can confirm whether the work is still available. If that contributor is actively implementing the fix, I am happy to defer or adapt this branch based on maintainer guidance.Review focus
Please review the accepted expression syntax, behavior for missing JSONB keys and
NULL, and interactions withnot.,in,is null, and delete/update old-row filtering.