(Issue #27) Fix rendering stalling on multi-segment timelines#33
Open
SimonMav wants to merge 1 commit into
Open
(Issue #27) Fix rendering stalling on multi-segment timelines#33SimonMav wants to merge 1 commit into
SimonMav wants to merge 1 commit into
Conversation
Chunks from each clip start their timestamps at 0, so concatenating segments (or repeating one) makes the timestamps jump backwards. Chrome's VideoDecoder doesn't like that and closes the codec, which then spams "decode on a closed codec" errors and stalls the render. Rewrite the timestamps into one increasing sequence before decoding.
Collaborator
|
Interesting, thanks for the contribution! Can you provide a video and a screenshot of the timeline that produces such a bug? Like that I'll be able to reproduce the issue and rapidly check if your fix fixes it. It smells like a good fix because I had to implement something similar in the v3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunks from each clip start their timestamps at 0, so concatenating segments (or repeating one) makes the timestamps jump backwards. Chrome's VideoDecoder doesn't like that and closes the codec, which then spams "decode on a closed codec" errors and stalls the render.
Rendering would pause partway through and the console filled up with:
Happens whenever the timeline has more than one segment (or a segment repeated). Each clip's
chunks carry timestamps starting from 0, so once we stitch them together the
timestamps reset backwards at every boundary. The decoder rejects the
backwards jump, closes itself, and the setInterval keeps hammering decode()
on the dead codec, leading to the "pausing" and the error spam.
Fix is to renumber the timestamps into a single monotonic sequence before
feeding them to the decoder. Types (key/delta) are left untouched so the
mosh effect still works.