fix(ci): support Go 1.27 - #143
Merged
Merged
Conversation
- pin the Go type reported for json.RawMessage, which became an alias for jsontext.Value in Go 1.27 - bump golangci-lint to v2.13.2 (Go 1.27 typecheck support) and fix the new findings; skip goconst for tests - run go-junit-report via `go -C` with GOTOOLCHAIN=auto so older matrix Go versions can use the newer tools module Assisted-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MTahE2aZEDH5dF4b8R87Ko Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main and on the open dependabot PRs fails since the matrix picked up Go 1.27.
Go 1.27 turned
json.RawMessageinto an alias forjsontext.Value, so the parser now sets the Go package and type for it explicitly to keep the generated schema stable across Go versions. The old golangci-lint (v2.4.0) cannot type-check Go 1.27 export data, so it is bumped to v2.13.2 and the handful of new findings are addressed (reflect.Ptr->reflect.Pointer, a preallocation, a gofumpt reformat, andgoconstexcluded for tests likegosecalready is). The bumped tools module requires Go 1.26, and the runners pinGOTOOLCHAIN=local, so the junit step now invokes go-junit-report withgo -C .github/toolsandGOTOOLCHAIN=auto; unlike-modfile,-Clets the older matrix versions switch toolchains automatically.