chore: standardize Vite plugin, build, prerender and adapter diagnostics - #17253
Open
elliott-with-the-longest-name-on-github wants to merge 1 commit into
Open
elliott-with-the-longest-name-on-github wants to merge 1 commit into
elliott-with-the-longest-name-on-github wants to merge 1 commit into
Conversation
elliott-with-the-longest-name-on-github
added this pull request to stack #17254
September 28, 2026 22:17
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/e7fdd2ace3e4eaaf015df1c394e55886a034bb20Open in |
🦋 Changeset detectedLatest commit: e7fdd2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| node.start, | ||
| node.end, | ||
| `const ${fn} = prerender('unchecked', () => { throw new Error('Unexpectedly called prerender function. Did you forget to set { dynamic: true } ?') });` | ||
| `const ${fn} = prerender('unchecked', () => { throw new Error(${not_dynamic_message}) });` |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Vite plugin, build, prerender, and adapter diagnostics to the
@sveltejs/message-box-generated catalog.There are a very few instances where we actually need the string from the error (either to pass it to a configured function or to accumulate it or whatever). There's probably a great solution to doing this at scale (for example, a template that returns a message instead of throwing), but the need for it is so small that I just added a
capture_messagehelper function. It's kinda nasty but it's so niche I don't think it matters.Probably most impactfully, I stopped using
log.warninside of SvelteKit, instead delegating all warnings toconsole.warnvia our generated helpers, which is still formatted the same as it was before. I also reroutedlog.warntoconsole.warn, which AFAICT was the intent all along. There should be no real end-user-visible-change here.Stack created with GitHub Stacks CLI • Give Feedback 💬