Repository navigation
ci: bring repo up to podium/kubernetes-toolkit/debug-toolkit standard - #25
Merged
Merged
Conversation
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Signed-off-by: Steven Wade <steven@stevenwade.co.uk>
Owner
Author
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This post authored by my AgenC)
Summary
Real bugs found and fixed, verified by actually building and running the image, not just reading the Dockerfile:
commit-lint.yamlandpr-lint.ymlboth usedpull_request_target- the dangerous-workflow pattern already fixed on podium and kubernetes-toolkit.kustdiffused the deprecated::set-output::workflow command. Checked rather than assumed: GitHub postponed removing it indefinitely, so it's not currently broken, but it produces a deprecation warning on every run. Modernized to$GITHUB_OUTPUT's heredoc form - and removed the manual%0Anewline-escaping that went with the old mechanism, since the new one takes raw multiline text directly; keeping both would have shown literal%0Ain every PR comment instead of real line breaks.contents: write, butkustdiffnever pushes anything (confirmed by reading the whole script) - downgraded tocontents: read, matching what kustomize-diff-test's own real workflow already uses. Also fixed a misleading line of prose claiming the action "commits changes back to your PR" - it posts a comment, nothing is ever committed.safe_base_ref) inkustdiff.test.yml) - there was previously zero automated verification that the Docker image builds or thatkustdiffactually works. It builds the image, cloneskustomize-diff-test(the existing fixture repo), makes a deterministic change on a throwaway local branch, runs the action against it, and asserts the diff output is actually correct - not just that the command exited zero.helmv3binary/symlink alias (same fix as debug-toolkit) - nothing in this repo referenced it, and it's about to become actively misleading now that Helm tracks flux's version, which is currently v4.Also added, matching the established bar on the sibling repos: hadolint + shellcheck, Scorecard, Dependabot, SECURITY.md, CODEOWNERS, pinned/refreshed action SHAs, digest-pinned base image.
New:
scripts/upgrade-flux-versions.sh+ weeklymonitor-flux-versions.yml, keeping kustomize/Helm in step with what flux itself is built against (same derivation as kubernetes-toolkit: flux2's release -> Components changelog -> kustomize-controller/helm-controller go.mod). Uses the signed-commit mechanism (scripts/lib/signed-pr.sh, GitHub'screateCommitOnBranchAPI) from the start, since I already know localgit commitin CI produces unsigned commits that fail this repo'srequired_signaturesrule and DCO check - no need to rediscover either bug here.Test plan
--version) againstkustomize-diff-test's real fixtures, both the plain-kustomize path and the--enable-helmpath (a real Helm chart pull), before and after every change$GITHUB_OUTPUTmechanism produces correct, readable multiline output (real newlines, no%0A) for both the diff and no-diff casesscripts/upgrade-flux-versions.shdry-run against the real flux2/kustomize-controller/helm-controller APIs - correctly reports kustomize already in sync (5.8.1) and Helm needing a bump (3.19.2 -> 4.2.4, correctly flagged as a major-version crossing)hadolint/shellcheck --severity=errorclean; all workflow YAML parses