Repository navigation
Don't re-arm the read header timeout while a response is in flight - #154
Merged
fabianfett merged 2 commits intoOct 22, 2026
Merged
Conversation
### Motivation On HTTP/1.1, the read header timeout was re-armed on request `.end`. For bodyless requests, that happens before the response is written, so any response streaming longer than 30s (e.g. Server-Sent Events) was closed. ### Changes `RequestTimeoutHandler` now also observes outbound response parts. It re-arms the header timeout only after both the request and the response have ended. ### Result Streaming responses stay open. Keep-alive connections are still protected between requests.
fabianfett
requested review from
FranzBusch,
aryan-25 and
gjcairo
as code owners
October 21, 2026 22:41
aryan-25
approved these changes
Oct 22, 2026
Co-authored-by: Aryan Shah <aryan_shah@apple.com>
fabianfett
enabled auto-merge (squash)
October 22, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On HTTP/1.1, the read header timeout was re-armed on request
.end. For bodyless requests, that happens before the response is written, so any response streaming longer than 30s (e.g. Server-Sent Events) was closed.Changes
RequestTimeoutHandlernow also observes outbound response parts. It re-arms the header timeout only after both the request and the response have ended.Result
Streaming responses stay open. Keep-alive connections are still protected between requests.