Repository navigation
Conversation
FranzBusch
reviewed
Oct 26, 2026
FranzBusch
left a comment
Contributor
There was a problem hiding this comment.
I think this looks okay for now. In the future we can completely get rid of this allocation by making the reader and writer ~Escapable and using a MutableRef to share the state into the reader/writer and read it out after the response handler is done
aryan-25
marked this pull request as ready for review
October 26, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently allocate for a class in both the request reader and response writer. This class tracks whether the reader/writer have finished reading the request / writing the response. Both of these properties are read by the same caller. We can therefore save an allocation if we share this state across both the reader and writer.
Modifications
ExchangeStatetype which replaces the state classes of the reader and response writer.HTTP1ConnectionReuseCoordinatorto encapsulate the iterator moving logic required for connection re-use.Result
An allocation saved for each request.