Skip to content

Fix \w scalar semantics to match digits and underscore #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natecook1000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix \w scalar semantics to match digits and underscore #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/_StringProcessing/Engine/MEBuiltins.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,9 @@ extension String {
}
case .word:
if isScalarSemantics {
matched = scalar.properties.isAlphabetic && asciiCheck
matched = (scalar.properties.isAlphabetic
|| scalar.properties.numericType != nil
|| scalar == "_") && asciiCheck
} else {
matched = char.isWordCharacter && asciiCheck
}
Expand Down
11 changes: 11 additions & 0 deletions Tests/RegexTests/MatchTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,17 @@ extension RegexTests {
firstMatchTest(
#"(?S)\v"#, input: "\r\n", match: "\r", semanticLevel: .unicodeScalar)

// \w in scalar semantics must match letters, digits, and underscore
// (matching the same definition used in grapheme-cluster semantics),
// not just alphabetics.
matchTest(
#"\w"#,
("a", true),
("1", true),
("_", true),
(" ", false),
semanticLevel: .unicodeScalar)

matchTest(
#"[a]\u0301"#,
("a\u{301}", false),
Expand Down
Loading