Skip to content

[6.4] Fix optimized ASCII case-insensitive matching - #909

Merged
natecook1000 merged 1 commit into
release/6.4.xfrom
fix/6.4-ascii-bitset-case-folding
Oct 26, 2026
Merged

natecook1000 merged 1 commit into
release/6.4.xfrom
fix/6.4-ascii-bitset-case-folding

Conversation

@natecook1000

@natecook1000 natecook1000 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Cherry-pick of #893 for the release/6.4.x branch.

  • Explanation: In AsciiBitset, adding a character with case insensitivity enabled uses the wrong lower bound: 64, which is @, instead of 65 (A).
  • Issue: rdar://190999895
  • Scope: Very narrow: changes a single range boundary inside the regex matching engine.
  • Risk: Very low: only affects regex matching.
  • Testing: Existing and new unit tests.
  • Reviewed by: @stephentyrone

In AsciiBitset, adding a character with case insensitivity enabled uses the
wrong lower bound: 64, which is `@`, instead of 65 (`A`).
@natecook1000
natecook1000 merged commit c2485d4 into release/6.4.x Oct 26, 2026
24 checks passed
@natecook1000
natecook1000 deleted the fix/6.4-ascii-bitset-case-folding branch October 26, 2026 14:15
@natecook1000 natecook1000 changed the title Fix optimized ASCII case-insensitive matching [6.4] Fix optimized ASCII case-insensitive matching Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants