Skip to content

[6.4] Match literal at end of sub-character substring - #914

Merged
natecook1000 merged 2 commits into
release/6.4.xfrom
fix/6.4-substring-sub-character-end
Oct 27, 2026
Merged

natecook1000 merged 2 commits into
release/6.4.xfrom
fix/6.4-substring-sub-character-end

Conversation

@natecook1000

@natecook1000 natecook1000 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Cherry-pick of #910 for the release/6.4.x branch.

  • Explanation: This fix changes the boundary check for substrings that have a sub-character end index, for which matching literals that end at the substring end boundary was failing.
  • Issue: rdar://190999851
  • Scope: Very narrow: this eliminates a boundary check inside the regex matching engine.
  • Risk: Very low: change is confined to regex matching.
  • Testing: New and existing unit tests.
  • Reviewed by: @stephentyrone

Matching was failing for substrings that have a sub-character end
index. This change fixes the boundary check for those cases, so that
the end of the subject bounds is always a boundary.

rdar://190999851
@natecook1000 natecook1000 changed the title Match literal at end of sub-character substring [6.4] Match literal at end of sub-character substring Oct 26, 2026
@natecook1000
natecook1000 merged commit d08dadb into release/6.4.x Oct 27, 2026
24 checks passed
@natecook1000
natecook1000 deleted the fix/6.4-substring-sub-character-end branch October 27, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants