fix: update hw activity explorer#1061
Open
piotr-iohk wants to merge 3 commits into
Open
Conversation
Hide the tx-details loading indicator for hardware wallet and transfer activities where inputs/outputs never load, while keeping it for regular on-chain transactions. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the hardware wallet activity explorer so it matches the hardware activity detail state.
The explorer now passes the hardware-wallet activity flag through to the shared activity icon, keeping hardware receive/send icons blue. It also stops showing an indefinite loading spinner when transaction inputs/outputs are unavailable, so hardware wallet activity exploration can still show the transaction id and block explorer action without implying details are still loading.
The loading spinner is kept for regular on-chain activities while tx details load, but hidden for hardware wallet activities and for transfers. Transfers are excluded so hardware wallet transfers do not show an indefinite spinner when inputs/outputs are unavailable; savings-to-spending transfers still load details normally, just without the spinner.
Preview
QA Notes
Manual Tests
regression:Normal on-chain activity → Activity Detail → Explore: transaction id, inputs/outputs when available, loading spinner while details load, and Open Block Explorer still work.Automated Checks
just compilepassed.