Upgrade trezor-connect-rs to 0.4.0#120
Open
coreyphillips wants to merge 1 commit into
Open
Conversation
Adapts to the 0.4.0 API: new optional fields on GetAddressParams, SignMessageParams, VerifyMessageParams and SignedTxResponse are covered with struct-update syntax so future additive fields do not break the build, and the deprecated (ignored) push field is no longer set. Note: 0.4.0 no longer defaults unset input sequences to RBF; bitkit-core passes the caller's sequence through unchanged, so callers wanting RBF must set 0xFFFFFFFD explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades trezor-connect-rs from 0.3.3 to 0.4.0 (release notes).
0.4.0 closes gaps against the JS upstream (@trezor/connect) and was verified end-to-end on a Trezor Safe 7 over USB:
Changes in this repo
..Default::default()), covering the new optional fields (chunkify, expected address) and dropping the deprecated ignoredpushfield, so future additive fields will not break the buildBehavior note for app layers
0.4.0 no longer silently defaults unset input sequences to 0xFFFFFFFD (RBF); the field is omitted so firmware applies its 0xFFFFFFFF (final) default, matching @trezor/connect. bitkit-core passes the caller's sequence through unchanged, so apps that want RBF must set
sequence = 0xFFFFFFFDexplicitly when building inputs.Test plan