Skip to content

fix(provider): add muse-spark-1.2 to meta provider - #3840

Open
gonzoga wants to merge 2 commits into
tailcallhq:mainfrom
gonzoga:feat/add-muse-spark-1.2
Open

fix(provider): add muse-spark-1.2 to meta provider#3840
gonzoga wants to merge 2 commits into
tailcallhq:mainfrom
gonzoga:feat/add-muse-spark-1.2

Conversation

@gonzoga

@gonzoga gonzoga commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Adds muse-spark-1.2 as a selectable model under the meta provider, alongside existing muse-spark-1.1.

Changes

  • crates/forge_repo/src/provider/provider.json:4452-4481 — Added hardcoded model entry:

    • id: muse-spark-1.2
    • context_length: 1048576 (verified via OpenRouter API, matches 1.1)
    • tools_supported, parallel_tool_calls, reasoning: true
    • input_modalities: ["text", "image"] (domain currently only supports Text/Image, upstream also has video/file/audio but parity with 1.1 maintained)
    • description: Meta's latest multimodal model for agentic tool calling etc.

  • crates/forge_repo/src/provider/provider_repo.rs:983-1023 — Updated test_meta_config to loop over both models and assert count == 2.

Verification

Verified capabilities via:

  • OpenRouter /api/v1/models shows both 1.1 and 1.2 have identical architecture text+image+file+audio+video->text and context 1048576
  • DuckDuckGo search snippets confirm 1.2 retains 1.1's 1M context and pricing, with improved coding accuracy and tool calling
  • cargo test -p forge_repo --lib provider::provider_repo::tests::test_meta_config passes
  • Full forge_repo lib suite: 333 passed

No JSON validity issues, no other providers modified.

Fixes: user request to add muse spark 1.2 to meta model options

@github-actions github-actions Bot added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: provider Updates provider.json configuration. labels Aug 11, 2026
@gonzoga gonzoga changed the title feat(provider): add muse-spark-1.2 to meta provider chore(provider): add muse-spark-1.2 to meta provider Aug 11, 2026
@gonzoga gonzoga changed the title chore(provider): add muse-spark-1.2 to meta provider fix(provider): add muse-spark-1.2 to meta provider Aug 11, 2026
@gonzoga @forge-code-agent
fix(provider): add muse-spark-1.2 to meta provider
453f7cc 
Adds llama-4-scout-17b-16e-instruct replacement? No - adds muse-spark-1.2 model alongside existing 1.1 with identical capabilities (1M context, tools, parallel tool calls, reasoning, image input). Verified via OpenRouter API that 1.2 retains same architecture and context length.

Co-Authored-By: ForgeCode <noreply@forgecode.dev>
@gonzoga
gonzoga force-pushed the feat/add-muse-spark-1.2 branch from 5352a11 to 453f7cc Compare August 11, 2026 18:57
@github-actions github-actions Bot added the type: fix Iterations on existing features or infrastructure. label Aug 11, 2026
@gonzoga

gonzoga commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Note: This should be labeled type: fix instead of type: feature (commit and title updated to fix(provider):).

Current labels still show type: feature because contributor permissions don't allow label edits via API (RemoveLabelsFromLabelable permission denied).

Please remove type: feature and ensure type: fix is present so this is categorized under Bug Fixes / patch release, not Features / minor.

/cc @maintainers

@laststylebender14 @gonzoga
chore: allow clippy::double_must_use at workspace level
99be797 
Newer clippy nightlies flag #[async_trait]-generated methods (which return
an already-must-use Pin<Box<dyn Future>> with an implicit #[must_use]) as
double_must_use, breaking the Lint Fix CI job on all branches. Allow the
lint workspace-wide via [workspace.lints] and opt every crate in.
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions Bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure. type: provider Updates provider.json configuration.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonzoga @laststylebender14