Skip to content

cmd/setec: disable SA4023 for build-tagged variants - #169

Merged
creachadair merged 1 commit into
mainfrom
mjf/suppress-warning
Aug 24, 2026
Merged

cmd/setec: disable SA4023 for build-tagged variants#169
creachadair merged 1 commit into
mainfrom
mjf/suppress-warning

Conversation

@creachadair

Copy link
Copy Markdown
Member

On Darwin and other non-Linux platforms, the TPM key support complains that the
error check can never be false. Disable that check in this one case.

@creachadair
creachadair requested a review from andrew-d August 24, 2026 21:59
@creachadair

Copy link
Copy Markdown
Member Author

the test failure will resolve after #170.

@creachadair
creachadair force-pushed the mjf/suppress-warning branch from 7f40287 to f42ae21 Compare August 24, 2026 22:07
On Darwin and other non-Linux platforms, the TPM key support complains that the
error check can never be false. Disable that check in this one case.
@creachadair
creachadair force-pushed the mjf/suppress-warning branch from f42ae21 to 623ee07 Compare August 24, 2026 22:17

@andrew-d andrew-d left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thank you.

@creachadair

Copy link
Copy Markdown
Member Author

Oh good catch, thank you.

All credit to staticcheck 😅

@creachadair
creachadair merged commit 0d7f78a into main Aug 24, 2026
1 check passed
@creachadair
creachadair deleted the mjf/suppress-warning branch August 24, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants