Skip to content

fix: serialize attributes through quoteAttribute in removeWhitespace #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taoqf merged 1 commit into from
Jun 29, 2026
Merged

fix: serialize attributes through quoteAttribute in removeWhitespace #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/nodes/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,9 @@ export default class HTMLElement extends Node {
// remove whitespace between attributes
const attrs = Object.keys(this.rawAttributes)
.map((key) => {
const val = this.rawAttributes[key];
return `${key}=${JSON.stringify(val)}`;
const val = this.quoteAttribute(this.rawAttributes[key]);
if (val === 'null' || val === '""') return key;
return `${key}=${val}`;
})
.join(' ');
this.rawAttrs = attrs;
Expand Down
9 changes: 9 additions & 0 deletions test/tests/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,15 @@ describe('HTML Parser', function () {
parseHTML('<p>\t\nHello\n\t<em>World</em>!</p>').removeWhitespace().firstChild.text.should.eql('HelloWorld!');
parseHTML('<p>\t\n Hello \n\t<em>World</em>!</p>').removeWhitespace().firstChild.text.should.eql(' Hello World!');
});

it('should preserve consecutive backslashes in attribute values', function () {
const html = '<a data-x="C:\\\\Users\\\\me">x</a>';
parseHTML(html).removeWhitespace().firstChild.toString().should.eql(html);
});

it('should preserve valueless attributes', function () {
parseHTML('<input disabled required>').removeWhitespace().firstChild.toString().should.eql('<input disabled required>');
});
});

describe('#rawAttributes', function () {
Expand Down