Repository navigation
Fix CMake 4 and GCC 15 - #80
Merged
Merged
Conversation
driver.c calls strcmp() without including string.h. GCC 14 turned an implicit function declaration into an error [1]: | .../mysql/driver.c:647:29: error: implicit declaration of function | 'strcmp' [-Wimplicit-function-declaration] [1]: https://gcc.gnu.org/gcc-14/porting_to.html#implicit-function-declaration Drafted by an LLM, conducted and corrected by the commit author. Part of #79
The bundled connector fails to configure with CMake 4.0+: it requires CMake 2.8 and sets policies to OLD behavior, and CMake 4.0 removed both [1]: | CMake Error at mariadb-connector-c/CMakeLists.txt:5 | (CMAKE_MINIMUM_REQUIRED): | Compatibility with CMake < 3.5 has been removed from CMake. | <...> | CMake Error at mariadb-connector-c/CMakeLists.txt:13 (CMAKE_POLICY): | Policy CMP0026 may not be set to OLD behavior because this version | of CMake no longer supports it. It also fails to compile with GCC 15, which defaults to C23, where `bool` is a keyword [2]: | .../include/ma_global.h:722:25: error: 'bool' cannot be defined via | 'typedef' Ubuntu 26.04 ships both. The submodule update brings the upstream fixes for these problems and a C23 fix for the io wait callback, which only the fork has. [1]: https://cmake.org/cmake/help/v4.0/release/4.0.html#deprecated-and-removed-features [2]: https://gcc.gnu.org/gcc-15/porting_to.html#c23-new-keywords Drafted by an LLM, conducted and corrected by the commit author. Fixes #79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See details in the commit messages.
Drafted by an LLM, conducted and corrected by the commit author.
Fixes #79