Repository navigation
core: fix missing _VERSION on read-write instances - #269
Open
nsadovskiy wants to merge 1 commit into
Open
nsadovskiy wants to merge 1 commit into
nsadovskiy wants to merge 1 commit into
Conversation
`queue._VERSION` was set only on the stub that `require('queue')`
returns while the queue cannot start yet. If the instance was already
in read-write mode when the module was loaded, `require('queue')`
returned the `queue.abstract` table itself, and that table has no
`_VERSION`. So the field was `nil` on masters and routers, and it was
set only on read-only replicas.
Declare `_VERSION` in `queue.abstract`, which becomes the module or is
copied into it on every start path, and make the stub take the value
from there.
Closes tarantool#260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queue._VERSIONwas set only on the stub thatrequire('queue')returns while the queue cannot start yet. If the instance was already in read-write mode when the module was loaded,require('queue')returned thequeue.abstracttable itself, and that table has no_VERSION. So the field wasnilon masters and routers, and it was set only on read-only replicas.Declare
_VERSIONinqueue.abstract, which becomes the module or is copied into it on every start path, and make the stub take the value from there.Closes #260