Skip to content

tail: preserve pending lines during log rotation - #1340

Merged
bigbes merged 2 commits into
masterfrom
bigbes/tntp-3131-fix-log-rotation
Aug 6, 2026
Merged

tail: preserve pending lines during log rotation#1340
bigbes merged 2 commits into
masterfrom
bigbes/tntp-3131-fix-log-rotation

Conversation

@bigbes

@bigbes bigbes commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • switch cli/tail to tarantool/go-tail pinned to commit 0e16f7e
  • make rotation tests require pending records from the old file before reopening the replacement
  • cancel followers when watched log roots disappear while keeping unaffected application roots active
  • bound tail shutdown so tt log -f can exit when an upstream watcher does not stop

Closes TNTP-3131

@Mockird31
Mockird31 force-pushed the bigbes/tntp-3131-fix-log-rotation branch 4 times, most recently from 385b504 to ac427b4 Compare August 4, 2026 14:55
@bigbes
bigbes requested a review from Mockird31 August 5, 2026 13:13
@Mockird31
Mockird31 force-pushed the bigbes/tntp-3131-fix-log-rotation branch from ac427b4 to d963754 Compare August 5, 2026 20:54
@Mockird31
Mockird31 force-pushed the bigbes/tntp-3131-fix-log-rotation branch from d963754 to cd46057 Compare August 5, 2026 20:55
@bigbes r.inyakin
tail: harden rotation and removal handling
f1f6edc 
`tt log -f`: possible line loss/duplication on rename, hanging after a
watched log directory is removed, and lines written just as the file
was read to the end not showing up until the next write.

Closes TNTP-3131
@Mockird31
Mockird31 force-pushed the bigbes/tntp-3131-fix-log-rotation branch from cd46057 to f1f6edc Compare August 5, 2026 21:18
@Mockird31
Mockird31 marked this pull request as ready for review August 6, 2026 07:03
sssciel
sssciel approved these changes Aug 6, 2026
View reviewed changes
Comment thread cli/tail/follow_test.go
@bigbes
bigbes merged commit e8a5072 into master Aug 6, 2026
34 of 35 checks passed
@bigbes
bigbes deleted the bigbes/tntp-3131-fix-log-rotation branch August 6, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sssciel sssciel sssciel approved these changes
@Mockird31 Mockird31 Mockird31 approved these changes
@patapenka-alexey patapenka-alexey Awaiting requested review from patapenka-alexey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bigbes @sssciel @Mockird31 @elhimov