Skip to content

Give sibling Session catalog isolation checks a 60-second timeout #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taras merged 1 commit into from
Oct 26, 2026
Merged

Give sibling Session catalog isolation checks a 60-second timeout #995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/test-agent/src/SessionConfiguration.test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</Test>
</TestAgent>

<Test name="sibling nested Executions have independent catalogs">
<Test name="sibling nested Executions have independent catalogs" timeout="60s">

@taras taras Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking observation: the next-tightest bound on this fixture is now the consumer's 120-second CLI process budget, not a Test budget.

Consequence: the Node consumer at packages/test-agent/tests/session-configuration.test.ts runs this whole document once through the CLI under RUN = { timeout: 120_000 }. On the Linux runner that subtest measured 90.7 s, 93.5 s and 93.9 s across the three recent test-node (5/10) jobs (runs 40382163496, 40372864525, 40382259777), so about 26 s of headroom remains. If worker startup cost grows further, that bound trips before any Test budget and reports as a CLI exit code rather than a named Test, which is a worse diagnostic than the one #994 produced.

Evidence: the duration_ms of runs configured Sessions and nested declarations through the source CLI and ACPX worker in each job log linked above. Related: packages/test-agent/tests/session-configuration.test.ts is still unmeasured in test-weights.json and is charged the heaviest recorded Node weight (176 s) while it actually ran 223 s in run 40382259777; the shard log says so on its first lines.

Recommendation: no change in this PR. If the CLI bound trips, raise that consumer's RUN.timeout or split the CLI pass; do not raise the 20-second <Test> default. The next measure-test-weights run records this file's real weight.

<Execution host="run" source={'<Agent name="reviewer"><Session name="defaults"><Prompt>defaults</Prompt></Session><Session name="defaults" model="fixture-small" effort="high"><Prompt>changed</Prompt></Session></Agent>'} as="first">
<TestAgent agent="reviewer"><TestAgent.Scenario session="defaults" src="./SessionConfiguration.defaults.md" models={catalog} /></TestAgent>
<AssertEquals actual={first.result.ok} expected={true} />
Expand Down
Loading