Repository navigation
Keep pnpm-lock.yaml a single document so Dependabot sees dependencies - #43
Merged
Merged
Conversation
[High impact] The PR appears safe to merge; no concrete failure was found. Reviews (1) · Last reviewed commit: "Keep pnpm-lock.yaml a single document so..." · Reviewed by Greptile |
emanuelatplain
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 12 writes its own pinned version as a first YAML document in
pnpm-lock.yaml. GitHub's dependency graph reads only that document, so the SBOM dropped to direct dependencies and Dependabot auto-closed alerts as "fixed" while the vulnerable versions were still locked (dependabot/dependabot-core#15904).pmOnFail: ignoreinpnpm-workspace.yamlso pnpm stops writing that documentpnpm-lock.yaml; the dependency document is unchanged byte for bytepnpm/setup, which readspackageManager, so CI is unaffected. Locally, pnpm no longer auto-switches to the pinned versionNote
Low Risk
Lockfile and workspace config only; restores correct SBOM/Dependabot visibility with no application or runtime behavior changes.
Overview
Fixes Dependabot and GitHub’s dependency graph by keeping
pnpm-lock.yamlas a single YAML document instead of pnpm 12’s leading “package manager only” block.Adds
pmOnFail: ignoreinpnpm-workspace.yaml(with a short comment linking dependabot-core#15904) so pnpm stops re-inserting that first document. Removes the existing env/pm pin document frompnpm-lock.yaml; the dependency lock content is unchanged.packageManagerinpackage.jsonstill pins pnpm for CI viapnpm/setup; locally, pnpm no longer auto-switches to the pinned version when the lockfile doc is gone.Reviewed by Cursor Bugbot for commit 7b6fe40. Bugbot is set up for automated code reviews on this repo. Configure here.