Skip to content

fix(ci): Persist release versions through generation - #181

Merged
philprime merged 2 commits into
mainfrom
philprime/fix/persist-release-version
Sep 10, 2026
Merged

fix(ci): Persist release versions through generation#181
philprime merged 2 commits into
mainfrom
philprime/fix/persist-release-version

Conversation

@philprime

Copy link
Copy Markdown
Member

Make project.yml the single source of truth for marketing and build versions. Fastlane now patches it with yq before XcodeGen runs, preventing generation from restoring stale release values.

Failure addressed

The latest Publish to App Store run selected build 5 from TestFlight, then make generate recreated the Xcode project with build 4. App Store validation rejected that duplicate build. This also fixes the malformed Fastlane version comparison and fails closed when remote version lookup fails.

Release version commits and artifacts now carry project.yml instead of directly edited Xcode project settings.

Verification

  • Reproduced a build 5 mutation and confirmed it survives XcodeGen regeneration
  • Confirmed Flinky, ShareExtension, and FlinkyCore resolve version 1.1.7 and build 4
  • make build-ios-app
  • make lint
  • actionlint .github/workflows/release.yml
  • bundle exec fastlane lanes
  • Repository pre-commit hooks

Use project.yml as the version source of truth so XcodeGen cannot overwrite release values selected from App Store Connect and TestFlight.
@sentry

sentry Bot commented Sep 10, 2026

Copy link
Copy Markdown

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
Flinky com.techprimate.Flinky 1.1.7 (4) --

⚙️ flinky Build Distribution Settings

@philprime
philprime marked this pull request as ready for review September 10, 2026 08:51
@philprime
philprime enabled auto-merge (squash) September 10, 2026 08:57
@sentry

sentry Bot commented Sep 10, 2026

Copy link
Copy Markdown

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
com.techprimate.Flinky
com.techprimate.Flinky
- - - - - - ✅ 4 uploaded

Base commit d35abf509433c7b0ac3828383ba8260750c8b53e did not produce snapshots to compare against. Did its snapshot job fail? Try rebasing this branch on a commit with a successful snapshot job.

⚙️ flinky Snapshot Settings

@philprime
philprime disabled auto-merge September 10, 2026 09:18
@philprime
philprime merged commit a5ffe21 into main Sep 10, 2026
6 of 7 checks passed
@philprime
philprime deleted the philprime/fix/persist-release-version branch September 10, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant