test(client): Consolidate HTTP test transports - #26
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
September 15, 2026 13:46
philprime
enabled auto-merge (squash)
September 15, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace nine private HTTP test doubles with one shared, URL-keyed transport that supports HTTP responses, arbitrary responses, failures, and request recording. Keep scenario fixtures local and leave production code and rendering unchanged.
Unexpected requests now record a test failure even when the client catches the error. A focused helper test verifies this using an intentional known issue.
Verification
make testpassed with 114 tests and the intentional known issue above.make analyzepassed, andmake buildconfirmed the release binary is up to date.