Skip to content

bump(deps): bump github.com/openshift-pipelines/pipelines-as-code version to v0.51.0 - #4183

Open
pratap0007 wants to merge 2 commits into
tektoncd:mainfrom
pratap0007:bump-PAC
Open

bump(deps): bump github.com/openshift-pipelines/pipelines-as-code version to v0.51.0#4183
pratap0007 wants to merge 2 commits into
tektoncd:mainfrom
pratap0007:bump-PAC

Conversation

@pratap0007

@pratap0007 pratap0007 commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 29, 2026
@tekton-robot

tekton-robot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pratap0007 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.35%. Comparing base (2deebfe) to head (c3b46da).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4183      +/-   ##
==========================================
+ Coverage   30.25%   30.35%   +0.10%     
==========================================
  Files         478      478              
  Lines       23169    23221      +52     
==========================================
+ Hits         7010     7049      +39     
- Misses      16159    16172      +13
Flag Coverage Δ
unit-tests 30.35% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2026
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2026
@pratap0007

pratap0007 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@pratap0007
pratap0007 force-pushed the bump-PAC branch 2 times, most recently from e5f0f9e to a73accd Compare October 1, 2026 04:59
@pratap0007

pratap0007 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@pratap0007

pratap0007 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@jkhelil jkhelil mentioned this pull request Oct 2, 2026
Draft
4 tasks
@pratap0007
pratap0007 force-pushed the bump-PAC branch 2 times, most recently from 1a93148 to 20f4d9b Compare October 5, 2026 07:33
@jkhelil

jkhelil commented Oct 6, 2026

Copy link
Copy Markdown
Member

@pratap0007
still missing :

  • Update preUpgradePipelinesAsCodeArtifacts (do not add a new function , the whole list re-runs on operator version change). Delete type keys from TektonConfig, OpenShiftPipelinesAsCode CR, and the pipelines-as-code ConfigMap; keep the https://artifacthub.io/api/v1 → https://artifacthub.io URL migration.
  • Update docs Docs still treat catalog-{INDEX}-type as required (docs/OpenShiftPipelinesAsCode.md, docs/TektonConfig.md).
  • Run an upgrade test

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2026
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2026
@pratap0007
bump(deps): bump github.com/openshift-pipelines/pipelines-as-code to …
8a4b7d7 
…v0.51.0

Signed-off-by: pratap0007 <shverma@redhat.com>
@pratap0007

pratap0007 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Before upgrade:
Screenshot From 2026-10-13 13-40-23
Screenshot From 2026-10-13 13-39-18

After upgrade
Screenshot From 2026-10-13 13-45-46

@pratap0007
fix(pipelinesascode): remove hub-catalog-type
c3b46da 
Pipelines as Code 0.51.0 no longer accepts hub-catalog-type.
Drop that key on upgrade from TektonConfig, the Pipelines as
Code CR, and the pipelines-as-code ConfigMap. Use a JSON merge
patch so the ConfigMap key is actually deleted, and strip it
again during reconcile so a later apply cannot restore it.

Signed-off-by: prratap0007 <shverma@redhat.com>
@pratap0007

pratap0007 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

@jkhelil I have updated PR, could you please take a look

jkhelil
jkhelil reviewed Oct 15, 2026
View reviewed changes
Comment thread .gitignore
Session.vim
# temporary
.netrwhist
<<<<<<< HEAD

@jkhelil jkhelil Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts

Comment thread .gitignore
=======
# auto-generated tag files
/tags
>>>>>>> 20f4d9bea (bump(deps): bump github.com/openshift-pipelines/pipelines-as-code to v0.51.0)

@jkhelil jkhelil Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here resolve conflicts

Comment thread pkg/reconciler/kubernetes/pipelinesascode/kubernetes_extension.go

func (e kubernetesExtension) PostReconcile(ctx context.Context, comp v1alpha1.TektonComponent) error {
logger := logging.FromContext(ctx)
if err := pacctrl.RemoveHubCatalogTypeFromConfigMap(ctx, e.kubeClientSet, comp.GetSpec().GetTargetNamespace()); err != nil {

@jkhelil jkhelil Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is called in PostReconcile on every reconcile for both platforms. Once hub-catalog-type is removed (which pre_upgrade already ensures on the first operator upgrade), every subsequent reconcile still pays a ConfigMap.Get() API call — forever. This is unnecessary steady-state overhead and contradicts the "pre_upgrade runs once per operator version change" design intention.

@jkhelil jkhelil Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to this call, the key is already removed via
dropConfigMapDataKeys
preUpgradePipelinesAsCodeArtifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkhelil jkhelil jkhelil left review comments
@enarha enarha Awaiting requested review from enarha
@pramodbindal pramodbindal Awaiting requested review from pramodbindal

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pratap0007 @tekton-robot @jkhelil