Repository navigation
Conversation
Users can set the rest of the Results API options from TektonConfig instead of editing tekton-results-api-config by hand. An unset field keeps the value shipped with Results. kube-api-qps and kube-api-burst stay on spec.result.performance. The API receives them as K8S_QPS and K8S_BURST. The watcher receives them as -qps and -burst, which are the flags that binary accepts.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4229 +/- ##
==========================================
+ Coverage 30.25% 30.53% +0.27%
==========================================
Files 478 478
Lines 23169 23274 +105
==========================================
+ Hits 7010 7106 +96
- Misses 16159 16168 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
olegbet
left a comment
olegbet
left a comment
There was a problem hiding this comment.
No validation has been added for new fields to pkg/apis/operator/v1alpha1/tektonresult_validation.go.
sql_log_level and tls_min_version are effectively enums; db_max_idle_connections, db_max_open_connections, grpc_worker_pool, converter_db_limit should be >= 0.
Invalid values pass straight through and surface only as an API pod crash-loop.
Please suggest enum/range checks mirroring validateRouteTLSTermination (pkg/apis/operator/v1alpha1/tektonresult_validation.go:79).
sql_log_level and tls_min_version only accept the values Results understands. The connection pool, gRPC worker pool, and converter batch size must be zero or greater. TektonConfig and TektonResult both run these checks.
Added. sql_log_level and tls_min_version are checked as enums, and db_max_idle_connections, db_max_open_connections, grpc_worker_pool, and converter_db_limit must be >= 0. The same checks run for TektonConfig and TektonResult. The webhook now rejects them so the CR is not accepted with a value Results will drop. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olegbet The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
Changes
Expose the Results API settings that were missing from
TektonConfig.spec.result. The operator writes a set field intotekton-results-api-configand into theapicontainer. An unset field keeps the Results default.spec.result.performance.kube-api-qpsandkube-api-burstare unchanged as CRD fields. They are now also applied to the Results API asK8S_QPSandK8S_BURST. A fractional QPS is truncated there because the API field is an integer. The watcher receives the same values as-qpsand-burst.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes