Repository navigation
Conversation
make apply on OpenShift deployed the manifest default console plugin image (console-plugin:main, PatternFly 5), which does not work on OCP 4.22 and newer. The operator picks the image from IMAGE_PIPELINES_CONSOLE_PLUGIN on 4.22+ and from IMAGE_PIPELINES_CONSOLE_PLUGIN_LEGACY on older versions, and the default overlay set neither. Set both in the default overlay: the master build (PatternFly 6) for 4.22+ and the main build (PatternFly 5) for older versions. The operatorhub overlay is unchanged because the release tooling injects the product images. Signed-off-by: Khurram Baig <kbaig@redhat.com> Assisted-by: Claude Sonnet 5.5 (via OpenCode)
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4253 +/- ##
=======================================
Coverage 30.25% 30.25%
=======================================
Files 478 478
Lines 23169 23169
=======================================
Hits 7010 7010
Misses 16159 16159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest |
| @@ -2,3 +2,30 @@ namespace: openshift-operators | |||
| resources: | |||
There was a problem hiding this comment.
Why not add the two images entries to
config/openshift/base/operator.yaml,
release tooling already replaces both keys in operatorhub/openshift/config.yaml
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 participants
make apply on OpenShift deployed the manifest default console plugin image (console-plugin:main, PatternFly 5), which does not work on OCP 4.22 and newer. The operator picks the image from
IMAGE_PIPELINES_CONSOLE_PLUGIN on 4.22+ and from
IMAGE_PIPELINES_CONSOLE_PLUGIN_LEGACY on older versions, and the default overlay set neither.
Set both in the default overlay: the master build (PatternFly 6) for 4.22+ and the main build (PatternFly 5) for older versions. The operatorhub overlay is unchanged because the release tooling injects the product images.
Assisted-by: Claude Sonnet 5.5
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes